Skip to content

wrap Arc<Backtrace> in Option, saving memory when backtraces are disabled #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

wrap Arc<Backtrace> in Option, saving memory when backtraces are disabled #252

wants to merge 3 commits into from

Conversation

Firestar99
Copy link

@Firestar99 Firestar99 commented Oct 30, 2024 •
edited
Loading

This PR wraps all Arc<Backtrace> in Option, as to not have to allocate an Arc of a disabled Backtrace each time GPU memory is allocated with backtraces are disabled. This is probably a premature optimization, but it was so easy to implement I couldn't resist :D

I only tested the vulkan implementation and visualizer on Linux, I hope CI catches issues for the other platforms.

manon-traverse
manon-traverse approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@manon-traverse manon-traverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice small optimization. Thanks for your contribution! :D

@MarijnS95
Copy link
Member

I recall checking long ago that Backtrace::Captured { .. } used to be quite small back in the day, is that no longer the case?

Regardless, this saves us some bytes in the Arc too so I guess it's nice to have. There's nothing to do about the ambiguity between None and Some(Arc::new(Backtrace::Disabled)) but it is what it is :)

MarijnS95
MarijnS95 reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this PR I still wonder why the Backtrace is wrapped in an Arc; in e45e25a I wrote that that is to support "Cloneing" the Backtrace, but glancing at the implementation that is only because of mistakes in the ownership transfer in our fn allocate() code and copies for AllocationReport which should either not receive a Backtrace at all, or borrow it temporarily while the caller can view the backtrace.

@Firestar99
Copy link
Author

why the Backtrace is wrapped in an Arc

I don't have the time right now to investigate that further, feel free to do that yourself or leave the PR as is.

@Jasper-Bekkers Jasper-Bekkers mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 MarijnS95 left review comments

@manon-traverse manon-traverse manon-traverse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Firestar99 @MarijnS95 @manon-traverse